Skip to content

[HIGH] Pin js-yaml to fixed releases - #58339

Open
OskarEichler wants to merge 1 commit into
react:mainfrom
OskarEichler:codex/security-js-yaml
Open

[HIGH] Pin js-yaml to fixed releases#58339
OskarEichler wants to merge 1 commit into
react:mainfrom
OskarEichler:codex/security-js-yaml

Conversation

@OskarEichler

Copy link
Copy Markdown
Contributor

Summary

  • pin the Istanbul 3.x consumer to js-yaml 3.15.1
  • pin the Markdownlint 4.x consumer to js-yaml 4.3.1
  • update both existing lockfile entries without changing their major versions

Security impact

The existing 3.14.1 and 4.1.0 releases are affected by quadratic CPU denial-of-service issues in merge-key and ordered-map handling (GHSA-52cp-r559-cp3m, GHSA-5p4m-2wfm-xmqj, GHSA-h67p-54hq-rp68), plus prototype pollution in merge handling (GHSA-mh29-5h37-fv8m). The resolutions are needed because markdownlint-cli2 0.17.2 requests js-yaml 4.1.0 exactly while React Native still supports Node 20.

Verification

  • yarn install --frozen-lockfile --ignore-scripts
  • yarn why js-yaml confirmed only 3.15.1 and 4.3.1
  • yarn audit no longer reports js-yaml advisories
  • yarn build
  • yarn lint
  • yarn lint-markdown: 40 files, 0 errors
  • Babel preset and community CLI: 13 suites, 153 tests, 16 snapshots passed
  • git diff --check

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Warning

Missing Test Plan

Please add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Caution

Missing Changelog

Please add a Changelog to your PR description. See Changelog format

@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant